chore(aiagents): drop hooks-state.json cache, make reconcile stateless#84
Open
swarit-stepsecurity wants to merge 1 commit into
Open
Conversation
The managed entry in settings.json (claude-code) or config.toml (codex) is
already the only thing that controls whether the hot path runs — if the
entry is present, claude-code spawns the binary; if not, it doesn't. The
parallel `~/.stepsecurity/hooks-state.json` enable flag added a third
state ("installed but disabled") that doesn't exist from the agent's
perspective and that the hot path paid a process spawn + file read to
honor.
Removes the cache file, its schema types, and the hot-path Read; the
reconciler now just fetches and calls Install/Uninstall (both already
idempotent). Verified end-to-end on the Ubuntu test VM: cache file is
not recreated, settings.json entries remain intact, telemetry uploads
succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The managed entry in settings.json (claude-code) or config.toml (codex) is already the only thing that controls whether the hot path runs — if the entry is present, claude-code spawns the binary; if not, it doesn't. The parallel
~/.stepsecurity/hooks-state.jsonenable flag added a third state ("installed but disabled") that doesn't exist from the agent's perspective and that the hot path paid a process spawn + file read to honor.Removes the cache file, its schema types, and the hot-path Read; the reconciler now just fetches and calls Install/Uninstall (both already idempotent). Verified end-to-end on the Ubuntu test VM: cache file is not recreated, settings.json entries remain intact, telemetry uploads succeed.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues