Add type annotations, remove timeout parameter from send_one_ping()#33
Open
jdanford wants to merge 3 commits intostellarbit:masterfrom
Open
Add type annotations, remove timeout parameter from send_one_ping()#33jdanford wants to merge 3 commits intostellarbit:masterfrom
timeout parameter from send_one_ping()#33jdanford wants to merge 3 commits intostellarbit:masterfrom
Conversation
jdanford
force-pushed
the
type-annotations
branch
from
44866c7 to
bde60b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did my best to keep everything compatible with Python 3.5, will verify when I get a chance
EDIT: all good!