Fix preview basePath to match pr-preview-action deploy path#24
Open
kaankacar wants to merge 1 commit into
Open
Fix preview basePath to match pr-preview-action deploy path#24kaankacar wants to merge 1 commit into
kaankacar wants to merge 1 commit into
Conversation
`rossjrw/pr-preview-action` deploys previews to `<umbrella-dir>/pr-<N>` by default, but the workflow was building Next.js with `NEXT_BASE_PATH=/pr/<N>` (no `pr-` prefix). Asset URLs baked into the HTML were therefore looking for `/pr/22/_next/...` while the files were actually served at `/pr/pr-22/_next/...`, returning 404 and producing an unstyled preview. Add the `pr-` prefix so the basePath matches where the action publishes. Closes #23.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR preview GitHub Actions workflow so the Next.js basePath matches the directory structure used by rossjrw/pr-preview-action, preventing broken asset URLs (unstyled previews) on skills.stellar.org.
Changes:
- Adjust
NEXT_BASE_PATHfrom/pr/<N>to/pr/pr-<N>for PR preview builds. - Expand the workflow comments to document why the
pr-prefix is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
preview-pr.ymlwas building Next.js withNEXT_BASE_PATH=/pr/<N>whilerossjrw/pr-preview-actionactually deploys under/pr/pr-<N>/so asset URLs in the built HTML 404'd and previews rendered unstyled. Add thepr-prefix to the basePath so it matches the deploy path.Production is unaffected (this workflow only runs on
pull_request;deploy-pages.ymlis independent).