Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered and no blocking issues were identified.
Pull request overview
Standardizes --contract-id across contract commands while retaining --id as a visible alias.
Changes:
- Updated CLI argument definitions and error text.
- Regenerated help documentation.
- Added integration coverage for flag consistency.
File summaries
| File | Description |
|---|---|
FULL_HELP_DOCS.md |
Documents canonical flags and aliases. |
cmd/soroban-cli/src/key.rs |
Updates shared contract ID argument. |
cmd/soroban-cli/src/commands/contract/invoke.rs |
Adds the canonical flag and alias. |
cmd/soroban-cli/src/commands/contract/fetch.rs |
Adds the canonical flag and updates error text. |
cmd/soroban-cli/src/commands/contract/alias/add.rs |
Adds the canonical flag and alias. |
cmd/crates/soroban-test/tests/it/main.rs |
Registers the integration test module. |
cmd/crates/soroban-test/tests/it/contract_id_flag.rs |
Verifies flag consistency across commands. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
--contract-idthe canonical flag for referencing an existing contract across thecontractsubcommands (invoke,fetch,read,extend,restore,alias add), with--idkept as a visible alias. Previously these commands only accepted--id, whilestellar contract infoused--contract-idwith--idas an alias — so the flag naming was inconsistent.Why
The inconsistency is a trap for users and agents: a flag that works on
contract info(--contract-id) was rejected byinvoke/read/etc., and vice versa. Standardizing on--contract-ideverywhere (matchingcontract info) while keeping--idas an alias makes the naming predictable and fully backwards compatible.