Skip to content

fix(oxlint-config): allow require in CommonJS files - #268

Merged
jan-kubica merged 1 commit into
mainfrom
fix/cjs-require-imports
Nov 8, 2026
Merged

jan-kubica merged 1 commit into
mainfrom
fix/cjs-require-imports

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

typescript/no-require-imports (enabled in #265) reported every require in .cjs files, where there is no static import to use instead. libraryOverrides now turns it off for **/*.cjs. The override test now also checks that a require in a .js file is still reported.

Patch bump: it only removes findings.

@jan-kubica
jan-kubica enabled auto-merge November 8, 2026 09:15
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7a12523 and bffae6d.

Files selected for processing: 3

  • .changeset/cjs-require-imports.md
  • packages/oxlint-config/src/index.ts
  • packages/oxlint-config/src/library-overrides.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@jan-kubica
jan-kubica added this pull request to the merge queue Nov 8, 2026
Merged via the queue into main with commit 068263b Nov 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant