Publish macOS CLI tarballs in release workflow#457
Publish macOS CLI tarballs in release workflow#457androidshu wants to merge 2 commits intosteipete:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2af428bbee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/release-cli.yml
Outdated
| if: matrix.platform == 'linux' | ||
| uses: swift-actions/setup-swift@v3 |
There was a problem hiding this comment.
Install Swift toolchain for macOS matrix entries
Gating setup-swift to Linux means the macOS jobs compile with whatever swift version is preinstalled on the runner, which is not guaranteed to satisfy this repo’s // swift-tools-version: 6.2 requirement. In environments where the default macOS toolchain is older (notably Intel macos-13 images tied to older Xcode), swift build fails before packaging, so the new macOS tarballs are never published. Apply the same Swift version setup (or explicit Xcode selection) to macOS jobs to make release output deterministic.
Useful? React with 👍 / 👎.
|
Addressed the Codex review feedback: Swift 6.2.1 setup now runs for macOS jobs as well (not Linux-only), so both macOS matrix entries use an explicit toolchain before build/package. |
Summary
.github/workflows/release-cli.ymlfrom Linux-only to a cross-platform CLI release workflow.CodexBarCLI-v<tag>-macos-arm64.tar.gzCodexBarCLI-v<tag>-macos-x86_64.tar.gzREADME.md,docs/cli.md,docs/releasing-homebrew.md) to reflect the new macOS + Linux CLI asset matrix.Why
Intel macOS users can run
CodexBarCLI, but release assets currently only publish Linux CLI tarballs. Publishing macOS CLI tarballs closes that distribution gap and makes downstream package automation (including Homebrew formula updates) straightforward.Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-cli.yml")'swift build -c release --product CodexBarCLI./.build/release/CodexBarCLI --versionFollow-up
Homebrew tap formula updates are still required to consume the new macOS CLI tarballs.