Skip to content

Publish macOS CLI tarballs in release workflow#457

Open
androidshu wants to merge 2 commits intosteipete:mainfrom
androidshu:fix/macos-cli-release-assets
Open

Publish macOS CLI tarballs in release workflow#457
androidshu wants to merge 2 commits intosteipete:mainfrom
androidshu:fix/macos-cli-release-assets

Conversation

@androidshu
Copy link
Copy Markdown

Summary

  • Expand .github/workflows/release-cli.yml from Linux-only to a cross-platform CLI release workflow.
  • Keep existing Linux assets and add two macOS CLI tarballs on release:
    • CodexBarCLI-v<tag>-macos-arm64.tar.gz
    • CodexBarCLI-v<tag>-macos-x86_64.tar.gz
  • Preserve static Swift stdlib packaging for Linux only.
  • Update CLI-related docs (README.md, docs/cli.md, docs/releasing-homebrew.md) to reflect the new macOS + Linux CLI asset matrix.

Why

Intel macOS users can run CodexBarCLI, but release assets currently only publish Linux CLI tarballs. Publishing macOS CLI tarballs closes that distribution gap and makes downstream package automation (including Homebrew formula updates) straightforward.

Validation

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-cli.yml")'
  • swift build -c release --product CodexBarCLI
  • ./.build/release/CodexBarCLI --version

Follow-up

Homebrew tap formula updates are still required to consume the new macOS CLI tarballs.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2af428bbee

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 49 to 50
if: matrix.platform == 'linux'
uses: swift-actions/setup-swift@v3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install Swift toolchain for macOS matrix entries

Gating setup-swift to Linux means the macOS jobs compile with whatever swift version is preinstalled on the runner, which is not guaranteed to satisfy this repo’s // swift-tools-version: 6.2 requirement. In environments where the default macOS toolchain is older (notably Intel macos-13 images tied to older Xcode), swift build fails before packaging, so the new macOS tarballs are never published. Apply the same Swift version setup (or explicit Xcode selection) to macOS jobs to make release output deterministic.

Useful? React with 👍 / 👎.

@androidshu
Copy link
Copy Markdown
Author

Addressed the Codex review feedback: Swift 6.2.1 setup now runs for macOS jobs as well (not Linux-only), so both macOS matrix entries use an explicit toolchain before build/package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant