Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 605c65a021
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| primaryCustomLabel = "Usage unavailable" |
There was a problem hiding this comment.
Fallback to request label when Cursor plan cost is missing
Legacy Cursor accounts intentionally have cursorPlanCost == nil while still providing a valid request-based primary window (CursorStatusSnapshot.toUsageSnapshot computes primary from requestsUsed/requestsLimit). This branch unconditionally replaces the primary label with "Usage unavailable" whenever plan dollars are absent, so those users lose the only textual usage signal in the menu card despite having real usage data. Keep the percent/request label as a fallback when dollar data is unavailable.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| private func cursorMenuBarDollarText(snapshot: UsageSnapshot?) -> String? { | ||
| guard let cost = snapshot?.cursorPlanCost, cost.limit > 0 else { return nil } |
There was a problem hiding this comment.
Preserve Cursor menu bar text for request-based plans
The Cursor-specific early return routes all menu-bar text through cursorMenuBarDollarText, and that helper returns nil whenever cursorPlanCost is absent. For legacy request-based Cursor plans, plan cost is expected to be missing but primary usage is still valid, so brand+text mode now renders no text at all instead of usage. Falling back to the existing MenuBarDisplayText path when dollar data is unavailable would avoid regressing those accounts.
Useful? React with 👍 / 👎.
|
Hi, displaying dollars offers way better info for Cursor specifically than % as it can go over 100. |
|
Does it still make sense to support legacy Cursor accounts? I would just cut it, it has been a long time since they changed the pricing (4. 7. 2025). If lots of people somehow still have old accounts, we can put it back. I find it highly unlikely that people who use Codexbar will have legacy accounts. |
Summary
Tests
Refs: #398 (comment)
Fixes #398