Keep the hero copy on the left under RTL - #3514
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. Reviewed September 10, 2026, 4:27 AM ET / 08:27 UTC (Revision 5). ClawSweeper reviewWhat this changesKeeps Arabic and Persian landing-page text physically left of the artwork, preserves natural text alignment, removes a conflicting tablet reveal transform, and adds a changelog entry. Merge readiness✅ Ready for maintainer review The PR remains useful: current main and v0.58.0 retain the affected layout rules. The focused patch and inspected before/after screenshots support landing it, with no actionable correctness findings. Priority: P2 Review scores
Verification
How this fits togetherThe website language picker sets the page’s reading direction. Hero layout styles position translated copy beside fixed artwork and control the illustrated usage panel’s entrance animation. flowchart LR
A[Language picker] --> B[Page reading direction]
B --> C[Hero text alignment]
D[Viewport width] --> E[Responsive layout]
C --> E
E --> F[Copy beside fixed artwork]
G[Shared reveal transform] --> F
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Retain the focused CSS repair so translated text stays readable beside the artwork throughout the tablet reveal. Do we have a high-confidence way to reproduce the issue? Yes: selecting Arabic or Persian activates RTL flow against right-anchored artwork, and the unchanged main stylesheet explains the collision shown in the before screenshots. This review inspected source and supplied proof without executing the website. Is this the best way to solve the issue? Yes: the patch uses existing layout and animation rules without duplicating localization logic or changing stored preferences. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f5c94a11834b. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (4 earlier review cycles)
|
Keep hero copy on the physical left while following its reading direction. Remove the conflicting tablet transform so the popover reveal uses the shared scale. Co-authored-by: Yash Raj Pandey <yashpn62@gmail.com>
111a174 to
6de975a
Compare
|
Landed in 4865f98; #3511 is closed. The fix preserves the physical space beside the artwork while following Arabic/Persian reading direction, and removes the conflicting tablet reveal transform. The full local suite passed 1,058 selections in 89 groups on the first pass, with no retries or timeouts. Site syntax/localization checks, lint, independent P0–P2 review and final-head CI passed. Before/after screenshots and the 15-case local browser verification are in the PR body. Post-merge live verification passed on codexbar.app: Arabic and Persian desktop layouts and the 769px Arabic tablet layout have no text/panel overlap or horizontal overflow. GitHub Pages reports the merge deployed, and the stylesheet fetched through the live browser matches the reviewed file byte-for-byte (SHA-256 f88a3a0f772514d2995c9f339985a1cd5786e17281714feb8037c893e6fbddb1). Thanks @devYRPauli! Contributor credit and the Unreleased changelog entry are preserved. |


Fixes #3511.
Arabic and Persian hero copy stays physically left of the fixed artwork while text alignment follows its reading direction. Mobile keeps the existing stacked layout. The tablet popover also inherits the shared reveal scale: its previous tablet-only starting transform grew across the text before the more-specific animated rule settled it back down.
Real Chrome verification used the existing profile through the approved browser integration and a local server for the current checkout. The original desktop overlap was reproduced, and the site’s own language picker was exercised. Fifteen normal-layout cases cover Arabic/Persian at the 769/1023 tablet edges, 900px tablet, 1671/1280 desktop, and 768/375 mobile widths, with English controls. All final cases have zero text/illustration overlap and horizontal overflow; English placement is unchanged.
A frame-by-frame replay of the actual 769px reveal found six visible glyph-overlap frames with the original proposal; the additional transform cleanup reduced that to zero across 55 frames. Static fixed-transform measurements were supporting diagnostics, not substitutes for normal rendering.
node --check docs/site.js,node Scripts/check-site-locales.mjs(23 locales / 138 messages),make check, and independent P0–P2 review passed. The full repository suite passed all 1,058 selections in 89 groups on the first pass, with no retries or timeouts (951.1 seconds). Final-head CI passed: https://github.com/steipete/CodexBar/actions/runs/34454905234. After integrating main, the Swift source and tests are identical to the fully tested credential-guidance merge.Includes a 0.58.1 Unreleased entry. Thanks @devYRPauli!
Before, normal Arabic rendering overlaps the panel:
After, selected through the actual language picker with normal animation: