Add first-run onboarding#1194
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 27, 2026, 6:15 PM ET / 22:15 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR. The linked recording and source inspection provide high-confidence evidence of the new onboarding flow, and current main does not already have that flow. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the onboarding feature after maintainer sign-off on first-run provider/auth defaults and completion of the latest required checks. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. The linked recording and source inspection provide high-confidence evidence of the new onboarding flow, and current main does not already have that flow. Is this the best way to solve the issue? Yes with maintainer sign-off: the branch reuses SettingsStore/provider-detection paths and adds focused regression coverage. The remaining question is approval of first-run defaults and auth/settings behavior, not a concrete patch defect. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 83ed8e405541. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
e17c9ce to
2997303
Compare
2997303 to
eddfaba
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
Demo
https://karma-dory-nytv.here.now/codexbar-onboarding-demo.mp4
Screenshots
Notes
CodexBar.app; the standalone CLI remains headless.Finish Setup, CodexBar starts background work and opens the menu bar popover automatically.Validation
swift buildswift testswift test --filter 'CodexBarTests.SettingsStoreTests'make checkgit diff --checkcodex review --base origin/mainCodex review found a P3 preview issue where the Appearance preview kept Codex active even when only another provider was selected; fixed by driving the preview from selected providers and falling back to Codex only when the selection is empty.