Add support of AWS profile for Bedrock#1190
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 27, 2026, 10:37 AM ET / 14:37 UTC. Summary Reproducibility: not applicable. as a bug reproduction: this PR adds a new Bedrock auth capability. Source inspection confirms current main lacks AWS profile support, and the PR body supplies redacted after-fix CLI proof for the new path. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land this after maintainer auth-provider sign-off and normal project validation, keeping the saved-key upgrade behavior now present on the latest head. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this PR adds a new Bedrock auth capability. Source inspection confirms current main lacks AWS profile support, and the PR body supplies redacted after-fix CLI proof for the new path. Is this the best way to solve the issue? Yes, with maintainer sign-off. The shared resolver is the maintainable shape because API and history fetches use the same credential path, and the latest head now covers the saved-key upgrade case. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 83ed8e405541. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87f5fa1a60
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
4ef4b31 to
c995693
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Add AWS profile auth support for Bedrock provider
Proof (redacted):
Budget window
Screenshots
