Add Swedish localization#1186
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 27, 2026, 4:12 AM ET / 08:12 UTC. Summary Reproducibility: not applicable. this is a localization feature PR, not a bug report. Source inspection and key comparison cover the functional path, but they do not replace real app proof. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance: Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Merge the Swedish localization after contributor-supplied real app proof shows the language option and rendered Swedish UI, and maintainers are comfortable with the translation quality. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a localization feature PR, not a bug report. Source inspection and key comparison cover the functional path, but they do not replace real app proof. Is this the best way to solve the issue? Yes, the implementation path matches the existing language picker and AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 83ed8e405541. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
sv) localization with fullLocalizable.stringscoverageValidation
.stringsfiles withplutil -lintswift test --filter LocalizationBundleTestssuccessfullyNote: full
swift testcurrently has one unrelated failure inProviderStorageFootprintTests:forced scheduled storage refresh does not restart identical in flight scan.