Repository navigation
Only reject '-' in replace when it refers to an array (#212) - #223
Merged
Merged
Conversation
ReplaceOperation.apply rejected every path ending in '-', including paths where '-' names an object member. RFC 6901 gives '-' a special meaning only for arrays, so make_patch could emit a replace of an object member '-' that apply then refused. Move the check into the array branch. Replacing a missing '-' member of an object now raises JsonPatchConflict, like any other missing member, instead of InvalidJsonPatch. Drop the expectedFailure markers from test_roundtrip and test_replace_any_existing_location, which pass now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFifAtR66mm468E2xYSRmw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReplaceOperation.apply rejected every path ending in '-', including
paths where '-' names an object member. RFC 6901 gives '-' a special
meaning only for arrays, so make_patch could emit a replace of an
object member '-' that apply then refused.
Move the check into the array branch. Replacing a missing '-' member
of an object now raises JsonPatchConflict, like any other missing
member, instead of InvalidJsonPatch.
Drop the expectedFailure markers from test_roundtrip and
test_replace_any_existing_location, which pass now.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01AFifAtR66mm468E2xYSRmw