Repository navigation
Compare values in 'test' by JSON equality (#216) - #221
Merged
Merged
Conversation
RFC 6902, 4.6 compares numbers by value, but literals like true and false
are only equal to themselves. TestOperation compared with Python's !=,
which considers 1 and True (0 and False) equal, also inside arrays and
objects, so e.g. testing {"a": 1} for true passed.
'test' now compares with _json_equal: booleans only equal booleans,
numbers compare by value, so 1 and 1.0 still match, and arrays and
objects compare member by member. PatchOperation.__eq__ uses it too, so
patches that test for 1 and for true, which behave differently, are no
longer equal. _json_equal is stricter than ==, so equal operations still
have equal hashes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TsjXWEqUCRUcZxVUe4Tw5G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6902, 4.6 compares numbers by value, but literals like true and false
are only equal to themselves. TestOperation compared with Python's !=,
which considers 1 and True (0 and False) equal, also inside arrays and
objects, so e.g. testing {"a": 1} for true passed.
'test' now compares with _json_equal: booleans only equal booleans,
numbers compare by value, so 1 and 1.0 still match, and arrays and
objects compare member by member. PatchOperation.eq uses it too, so
patches that test for 1 and for true, which behave differently, are no
longer equal. _json_equal is stricter than ==, so equal operations still
have equal hashes.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01TsjXWEqUCRUcZxVUe4Tw5G