Repository navigation
Hash patch operations by their 'op' and 'path' (#217) - #220
Merged
Merged
Conversation
PatchOperation.__hash__ hashed a frozenset of all members, so hashing a patch raised TypeError when an operation's value was an array or object. Such patches couldn't go into sets or serve as dict keys. Hash only 'op' and 'path'. They are always hashable, since 'op' must be a string and 'path' a valid pointer, and operations that compare equal have equal 'op' and 'path', so their hashes stay equal. 'from' is left out: it is only validated when a move or copy is applied, and the RFC has other operations ignore it, so it can hold an array or object too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011nVTdpJFksiRYmZDJrV9SM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatchOperation.hash hashed a frozenset of all members, so hashing a
patch raised TypeError when an operation's value was an array or object.
Such patches couldn't go into sets or serve as dict keys.
Hash only 'op' and 'path'. They are always hashable, since 'op' must be
a string and 'path' a valid pointer, and operations that compare equal
have equal 'op' and 'path', so their hashes stay equal. 'from' is left
out: it is only validated when a move or copy is applied, and the RFC
has other operations ignore it, so it can hold an array or object too.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_011nVTdpJFksiRYmZDJrV9SM