Repository navigation
Require jsonpointer>=3.2 - #218
Merged
Merged
Conversation
jsonpointer 3.2 no longer resolves pointers into strings, which #178 requires. CI always installs the latest jsonpointer, so it never ran against an older version, where the _to_last helper added for #178 is what rejects such pointers. Requiring 3.2 makes the tested configuration the only supported one. jsonpointer 3.2 requires Python 3.10, as jsonpatch already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JqGXptMsaz9bfrMoaMpZ1A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the
jsonpointerrequirement inrequirements.txt(whichsetup.pyreads forinstall_requires) from>=1.9to>=3.2.Why
jsonpointer3.2 no longer resolves pointers into strings, which is what BUG: JSON Patch operations sometimes treat strings as arrays (RFC 6902 non-compliant) #178 requires. With older versions, the_to_lasthelper added in Prevent RFC 6901 pointer indexing into strings #196 is what rejects them. CI always installs the latestjsonpointer, so the helper never runs in CI: the code from before Prevent RFC 6901 pointer indexing into strings #196 passesStringIndexingTestsonjsonpointer3.2 too. Requiring 3.2 makes the tested configuration the only supported one.>=1.9is already inaccurate.tests.pyonly passes in full fromjsonpointer1.14 on. With 1.9–1.13, a patch with"path": nullraisesAttributeErrorinstead ofInvalidJsonPatch(test_path_with_null_value).No Python version is dropped:
jsonpointer3.2 requires Python ≥ 3.10, the same as jsonpatch'spython_requires.With 3.2 required, the
_to_lasthelper is redundant. This PR leaves it in place; it can be removed separately if wanted.Verification
jsonpointer3.2.0. Its metadata declaresjsonpointer>=3.2, and asking forjsonpointer==3.1.1alongside it fails as unsatisfiable.python tests.pypasses withjsonpointer3.2.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01JqGXptMsaz9bfrMoaMpZ1A
Generated by Claude Code