feat: add C implementation for stats/base/ndarray/snanmskmaxabs - #15161
Open
himayurjogade wants to merge 1 commit into
Open
feat: add C implementation for stats/base/ndarray/snanmskmaxabs#15161himayurjogade wants to merge 1 commit into
stats/base/ndarray/snanmskmaxabs#15161himayurjogade wants to merge 1 commit into
Conversation
Ref: stdlib-js#14034 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14034.
Description
This pull request:
@stdlib/stats/base/ndarray/snanmskmaxabs.tryRequiredispatcher with a fallback to theJavaScript implementation when the native addon is unavailable.
Related Issues
This pull request has the following related issues:
@stdlib/stats/base/ndarraypackages (tracking issue) #14034Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
AI assistance was used for reviewing changes, generating tests and benchmarks, and researching repository conventions.
I reviewed each file and verified the result locally: the native addon compiles without warnings, all 18 native test assertions pass with results consistent with the JavaScript implementation, the C example and C benchmarks run correctly, and ESLint reports no errors. Happy to make any adjustments reviewers would like.
@stdlib-js/reviewers