refactor: fix inconsistencies across packages in `blas/ext/base*` by headlessNode · Pull Request #15146 · stdlib-js/stdlib

headlessNode · 2026-09-10T14:17:51Z

Resolves stdlib-js/metr-issue-tracker#1316.

Description

What is the purpose of this pull request?

This pull request:

fix inconsistencies across packages in blas/ext/base*

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves [RFC]: fix inconsistencies across packages in blas/ext/base* metr-issue-tracker#1316.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

headlessNode · 2026-09-10T14:20:00Z

@kgryte This ended up being a lot bigger than I expected. The 'fixes' are mostly docs and tests related. I will updated the currently open related PR's as well.

stdlib-bot · 2026-09-10T14:43:15Z

Coverage Report

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

headlessNode · 2026-09-11T14:08:25Z

Expected benchmarks lint error due to time-out.

kgryte · 2026-09-11T16:41:37Z

    A complex number is truthy when at least one of its real or imaginary
    components is truthy.

-    If unable to find a truthy element, the function returns `-1`.


@headlessNode What is the rationale for removing this note?

I see it is not present in, say, cindex-of.

Yeah I used index-of family as canon for docs related changes. Except a few places.

Yes, I suppose that makes sense. Although, we should be careful, as these specializations should be allowed to have API-specific notes, where appropriate.

kgryte · 2026-09-11T16:41:52Z

    A complex number is truthy when at least one of its real or imaginary
    components is truthy.

-    If unable to find a truthy element, the function returns `-1`.


Same question.

kgryte · 2026-09-11T16:50:15Z

+    > var y0 = new {{alias:@stdlib/array/float64}}( [ 0.0, 0.0, 3.0, 0.0 ] );
    > var y1 = new {{alias:@stdlib/array/float64}}( y0.buffer, y0.BYTES_PER_ELEMENT*1 );
-    > idx = {{alias}}( 2, x1, 1, y1, 1 )
+    > var idx = {{alias}}( 2, x1, 1, y1, 1 )


Suggested change

> var idx = {{alias}}( 2, x1, 1, y1, 1 )

> idx = {{alias}}( 2, x1, 1, y1, 1 )

This isn't correct. You've already declared idx at L42 above.

kgryte · 2026-09-11T16:54:00Z

-    -1
+    > var y0 = new {{alias:@stdlib/array/float64}}( [ 9.0, 9.0, 0.0, 9.0 ] );
+    > var y1 = new {{alias:@stdlib/array/float64}}( y0.buffer, y0.BYTES_PER_ELEMENT*1 );
+    > var idx = {{alias}}( 2, x1, 1, y1, 1 )


Suggested change

> var idx = {{alias}}( 2, x1, 1, y1, 1 )

> idx = {{alias}}( 2, x1, 1, y1, 1 )

Same comment. You should go back through and ensure we are not redeclaring in these files.

kgryte · 2026-09-11T16:58:03Z

-	var x;
-	var y;
-
-	x = new Float64Array( [ 1.0, 2.0, 3.0 ] );


Why are we refactoring to inline here? The test cases are simpler when you use separate variables x and y here.

kgryte · 2026-09-11T16:58:23Z

-	y = new Float64Array( [ 1.0, 2.0, 3.0 ] );

-	actual = dfirstIndexLessThan( 0, x, 1, y, 1 );
+	actual = dfirstIndexLessThan( 0, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1 );


Same question. Why inline?

kgryte · 2026-09-11T16:58:37Z

-	y = new Float64Array( [ 1.0, 2.0, 3.0 ] );

-	actual = dfirstIndexLessThan( 0, x, 1, 0, y, 1, 0 );
+	actual = dfirstIndexLessThan( 0, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1, 0, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1, 0 );


Same question.

kgryte · 2026-09-11T16:58:48Z

-	y = new Float64Array( [ 1.0, 2.0, 3.0 ] );

-	actual = dfirstIndexLessThan( 0, x, 1, 0, y, 1, 0 );
+	actual = dfirstIndexLessThan( 0, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1, 0, new Float64Array( [ 1.0, 2.0, 3.0 ] ), 1, 0 );


Same question.

kgryte · 2026-09-11T17:01:02Z

+    > var idx = {{alias}}( 3, x, 2 )
+    1
+
+    // Using view offsets:
+    > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0 ] );
+    > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
+    > var idx = {{alias}}( 3, x1, 2 )


Suggested change

> var idx = {{alias}}( 3, x, 2 )

1

// Using view offsets:

> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0 ] );

> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );

> var idx = {{alias}}( 3, x1, 2 )

> idx = {{alias}}( 3, x, 2 )

1

// Using view offsets:

> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0 ] );

> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );

> idx = {{alias}}( 3, x1, 2 )

Incorrect. Do not redeclare.

kgryte · 2026-09-11T17:01:15Z


+    // Using an index offset:
+    > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0 ] );
+    > var idx = {{alias}}.ndarray( 3, x, 2, 1 )


Suggested change

> var idx = {{alias}}.ndarray( 3, x, 2, 1 )

> idx = {{alias}}.ndarray( 3, x, 2, 1 )

kgryte · 2026-09-11T17:03:20Z

-	// Negative stride...
-	actual = dindexOfFalsy( x.length, x, -1 );
-	t.strictEqual( actual, 1, 'returns expected value' );
+tape( 'the function ignores truthy elements (e.g., non-zero values)', function test( t ) {


How is this test materially different than the one above?

I am not convinced it adds anything.

kgryte · 2026-09-11T17:03:52Z

-	// Negative stride...
-	actual = dindexOfFalsy( x.length, x, -1 );
-	t.strictEqual( actual, 1, 'returns expected value' );
+tape( 'the function ignores truthy elements (e.g., non-zero values)', opts, function test( t ) {


Same question in this and other test files.

kgryte · 2026-09-11T17:04:41Z

@@ -42,7 +42,7 @@
    > var idx = {{alias}}( 3, 1.0, x, 2 )


Suggested change

> var idx = {{alias}}( 3, 1.0, x, 2 )

> idx = {{alias}}( 3, 1.0, x, 2 )

kgryte · 2026-09-11T17:04:49Z

+    // Using view offsets:
    > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 1.0, 1.0 ] );
    > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
    > var idx = {{alias}}( 2, 1.0, x1, 1 )


Suggested change

> var idx = {{alias}}( 2, 1.0, x1, 1 )

> idx = {{alias}}( 2, 1.0, x1, 1 )

kgryte · 2026-09-11T17:05:04Z

    alternative indexing semantics.

    While typed array views mandate a view offset based on the underlying
    buffer, the offset parameter supports indexing semantics based on a


Line wrapping?

kgryte · 2026-09-11T17:05:13Z

-    // Advanced indexing:
+    // Using an index offset:
    > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 1.0, 3.0, 1.0, 4.0 ] );
    > var idx = {{alias}}.ndarray( 3, 1.0, x, 2, 1 )


Suggested change

> var idx = {{alias}}.ndarray( 3, 1.0, x, 2, 1 )

> idx = {{alias}}.ndarray( 3, 1.0, x, 2, 1 )

kgryte

Left initial comments. Still some clean-up to do.

headlessNode requested a review from a team September 10, 2026 14:17

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Sep 10, 2026

headlessNode marked this pull request as draft September 10, 2026 16:55

stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 10, 2026

headlessNode added 22 commits September 11, 2026 14:26

fix: refactor index-of

e0c0786

fix: refactor last-index-of

b841028

fix: refactor index-of-truthy

9bf61a3

fix: refactor index-of-falsy

4315045

fix: refactor last-index-of-truthy

80e83d7

fix: refactor last-index-of-falsy

291df78

fix: refactor index-of-not-equal

5184528

fix: refactor index-of-less-than

f3e6700

fix: refactor index-of-greater-than

29cf71b

fix: refactor index-of-greater-than-equal

8c0fc74

fix: refactor index-of-less-than-equal

a768d59

fix: refactor index-of-same-value

e1eb4c8

fix: refactor index-of-almost-same-value

446ae2a

docs: fix REPL examples in gindex-of-same-value

c28ed51

fix: refactor index-of-row

7a7bb7c

fix: refactor index-of-column

b766e73

docs: add matrix visualization comments in index-of-row

ec532f5

fix: refactor last-index-of-row

a257723

fix: refactor gindex-of-truthy-row and gindex-of-falsy-row

4403459

fix: refactor first-index-equal

7ccdfb7

fix: refactor first-index-less-than

3cead0b

fix: refactor first-index-greater-than

f9a0d7e

headlessNode added 7 commits September 11, 2026 14:26

fix: apply consistency fixes to index-of-truthy-row

563129f

fix: apply consistency fixes to find-index

e689746

fix: apply consistency fixes to find-last-index

2711b2e

fix: apply consistency fixes to first-index-almost-equal

467ffe1

fix: apply consistency fixes to last-index-greater-than

e90c56f

fix: apply consistency fixes to last-index-almost-same-value

36651b3

fix: apply consistency fixes to last-index-less-than

bce0dee

headlessNode force-pushed the blas/ref/index branch from 12c993b to bce0dee Compare September 11, 2026 10:07

headlessNode added 2 commits September 11, 2026 16:15

headlessNode marked this pull request as ready for review September 11, 2026 14:08

stdlib-bot added the Needs Review A pull request which needs code review. label Sep 11, 2026

kgryte reviewed Sep 11, 2026

View reviewed changes

kgryte requested changes Sep 11, 2026

View reviewed changes

	> var idx = {{alias}}( 2, x1, 1, y1, 1 )
	> idx = {{alias}}( 2, x1, 1, y1, 1 )

	> var idx = {{alias}}.ndarray( 3, x, 2, 1 )
	> idx = {{alias}}.ndarray( 3, x, 2, 1 )

	> var idx = {{alias}}( 3, 1.0, x, 2 )
	> idx = {{alias}}( 3, 1.0, x, 2 )

	> var idx = {{alias}}( 2, 1.0, x1, 1 )
	> idx = {{alias}}( 2, 1.0, x1, 1 )

	> var idx = {{alias}}.ndarray( 3, 1.0, x, 2, 1 )
	> idx = {{alias}}.ndarray( 3, 1.0, x, 2, 1 )

Uh oh!

Uh oh!

Conversation

headlessNode commented Sep 10, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

headlessNode commented Sep 10, 2026

Uh oh!

stdlib-bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

headlessNode commented Sep 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Sep 10, 2026 •

edited

Loading