Skip to content

test: adjust tolerance in math/base/special/hyp2f1 #11351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Apr 10, 2026
+21 −15
Merged

test: adjust tolerance in math/base/special/hyp2f1 #11351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f9be4c
test: adjust tolerance to account for compiler optimization
nirmaljb Apr 10, 2026
b16d66d
refactor: change to is-nan from is-nanf
nirmaljb Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/hyp2f1/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var hyp2f1 = require( './../lib' );
Expand Down Expand Up @@ -64,16 +64,16 @@ tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
var v;

v = hyp2f1( NaN, 3.0, 2.0, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, NaN, 2.0, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, 3.0, NaN, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, 3.0, 2.0, NaN );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

t.end();
});
Expand Down
26 changes: 16 additions & 10 deletions lib/node_modules/@stdlib/math/base/special/hyp2f1/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var tryRequire = require( '@stdlib/utils/try-require' );
Expand Down Expand Up @@ -73,16 +73,16 @@ tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) {
var v;

v = hyp2f1( NaN, 3.0, 2.0, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, NaN, 2.0, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, 3.0, NaN, 0.5 );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

v = hyp2f1( 0.0, 3.0, 2.0, NaN );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.strictEqual( isnan( v ), true, 'returns expected value' );

t.end();
});
Expand Down Expand Up @@ -167,7 +167,8 @@ tape( 'the function correctly evaluates the hypergeometric function', opts, func
t.strictEqual( v, PINF, 'returns expected value' );
continue;
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
// NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205
t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -193,7 +194,8 @@ tape( 'the function correctly evaluates the hypergeometric function', opts, func
t.strictEqual( v, PINF, 'returns expected value' );
continue;
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 7 ), true, 'returns expected value' );
// NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205
t.strictEqual( isAlmostSameValue( v, expected[ i ], 27 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -219,7 +221,8 @@ tape( 'the function correctly evaluates the hypergeometric function', opts, func
t.strictEqual( v, PINF, 'returns expected value' );
continue;
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 18 ), true, 'returns expected value' );
// NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205
t.strictEqual( isAlmostSameValue( v, expected[ i ], 45 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -245,7 +248,8 @@ tape( 'the function correctly evaluates the hypergeometric function', opts, func
t.strictEqual( v, PINF, 'returns expected value' );
continue;
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 33 ), true, 'returns expected value' );
// NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205
t.strictEqual( isAlmostSameValue( v, expected[ i ], 100 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -267,7 +271,9 @@ tape( 'the function correctly evaluates the hypergeometric function', opts, func

for ( i = 0; i < x.length; i++ ) {
v = hyp2f1( a[ i ], b[ i ], c[ i ], x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 294333 ), true, 'returns expected value' );

// NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205
t.strictEqual( isAlmostSameValue( v, expected[ i ], 391554 ), true, 'returns expected value' );
}
t.end();
});