chore: fix C lint errors (issue #11347)#11348
Merged
kgryte merged 4 commits intostdlib-js:developfrom Apr 10, 2026
Merged
Conversation
stdlib-bot
added
First-time Contributor
Closed
GuneetGill
force-pushed
the
chore/fix-linting
branch
from
4d09032 to
04a85e4
Compare
GuneetGill
force-pushed
the
chore/fix-linting
branch
from
04a85e4 to
eb8a43a
Compare
GeoDaoyu
reviewed
Apr 10, 2026
Contributor
GeoDaoyu
left a comment
GeoDaoyu
left a comment
There was a problem hiding this comment.
It seems that the code is not up-to-date.
...e_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 10, 2026
...e_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 10, 2026
lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 10, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Apr 10, 2026
kgryte
added
difficulty: 1
Contributor
Coverage ReportNo coverage information available. |
Member
|
Thank you for your contribution and congratulations on your first PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11347
Description
This pull request:
constVariablePointerwarning inunary-accumulateby declaring the strides pointers1asconst int64_t *, since it is only read after assignment fromstdlib_ndarray_strides.stdlib_ndarray_iteration_orderto takeconst int64_t *stridesin the public header and implementation, matching read-only use of strides and keeping thedispatch.ccall type-correct without casts.Checklist
AI Assistance
@stdlib-js/reviewers