Skip to content

feat: add ndarray/base/scalar-dtype (issue #11002)#11040

Closed
Suhaniahirwar20 wants to merge 1 commit intostdlib-js:developfrom
Suhaniahirwar20:scalar-dtype
Closed

feat: add ndarray/base/scalar-dtype (issue #11002)#11040
Suhaniahirwar20 wants to merge 1 commit intostdlib-js:developfrom
Suhaniahirwar20:scalar-dtype

Conversation

@Suhaniahirwar20
Copy link
Copy Markdown

Resolves #11002.

Description

What is the purpose of this pull request?

This pull request introduces a new utility @stdlib/ndarray/base/scalar-dtype to resolve a default ndarray data type from a scalar value.

Previously, scalar-to-dtype resolution logic was duplicated across multiple packages such as:

  • ndarray/base/atleastnd
  • ndarray/from-scalar

This PR extracts that logic into a reusable module, improving maintainability, consistency, and making it easier to extend support for additional data types in the future.

Changes include:

  • Adding new package @stdlib/ndarray/base/scalar-dtype
  • Refactoring ndarray/base/atleastnd to use the new utility
  • Removing duplicated scalar dtype resolution logic

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I consulted ChatGPT to better understand the existing codebase and refactoring approach. The implementation and final changes were written and verified manually.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 19, 2026
@github-actions github-actions bot mentioned this pull request Mar 21, 2026
@kgryte kgryte added autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. and removed Needs Review A pull request which needs code review. labels Apr 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not follow project conventions.

We place a high value on consistency throughout the stdlib codebase, and this pull request was found to significantly deviate from stdlib conventions. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

  • If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
  • If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
  • If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before continuing to work on this pull request.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add ndarray/base/scalar-dtype

3 participants