Skip to content

chore: remove unused rand_double helper in stats/strided/dmaxabssorted#10180

Merged
kgryte merged 3 commits intostdlib-js:developfrom
Om-A-osc:chore/stats-strided--dmaxabssorted
Apr 10, 2026
Merged

chore: remove unused rand_double helper in stats/strided/dmaxabssorted#10180
kgryte merged 3 commits intostdlib-js:developfrom
Om-A-osc:chore/stats-strided--dmaxabssorted

Conversation

@Om-A-osc
Copy link
Copy Markdown
Contributor

@Om-A-osc Om-A-osc commented Feb 9, 2026


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames
    status: passed
  • task: lint_editorconfig
    status: passed
  • task: lint_markdown
    status: na
  • task: lint_package_json
    status: na
  • task: lint_repl_help
    status: na
  • task: lint_javascript_src
    status: na
  • task: lint_javascript_cli
    status: na
  • task: lint_javascript_examples
    status: na
  • task: lint_javascript_tests
    status: na
  • task: lint_javascript_benchmarks
    status: na
  • task: lint_python
    status: na
  • task: lint_r
    status: na
  • task: lint_c_src
    status: na
  • task: lint_c_examples
    status: na
  • task: lint_c_benchmarks
    status: passed
  • task: lint_c_tests_fixtures
    status: na
  • task: lint_shell
    status: na
  • task: lint_typescript_declarations
    status: passed
  • task: lint_typescript_tests
    status: na
  • task: lint_license_headers
    status: passed

Resolves no issue.

Description

This pull request removes an unused helper function (rand_double) from the
stats/strided/dmaxabssorted benchmark code. The function was never referenced,
and its removal does not change behavior or benchmark results.

Related Issues

This pull request has no related issues.

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes
  • No

@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 9, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 9, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/strided/dmaxabssorted $\color{green}316/316$
$\color{green}+0.00%$
$\color{green}20/20$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}316/316$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 10, 2026

/stdlib merge

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 10, 2026
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 10, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 10, 2026
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit 167cf51 into stdlib-js:develop Apr 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants