Repository navigation
Avoid querying localizations for each alternate locale - #694
Open
joshuablum wants to merge 3 commits into
Open
joshuablum wants to merge 3 commits into
joshuablum wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
duncanmcclean
marked this pull request as draft
October 14, 2026 10:10
joshuablum
marked this pull request as ready for review
October 14, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reduces the number of queries needed to build the alternate locales (hreflang tags), which could result in hundreds of queries on multisite installs using the Eloquent driver.
This was happening because the cascade called
$entry->in($locale)twice for every other site: once to check whether the localization is published, and once to get its URL. Since Statamic 6.20.2 (statamic/cms#14773),Entry::descendants()loads the localization tree with one query per level, but the result isn't cached. So everyin()call now queries the entry's descendants again, which makes the number of queries grow with the number of sites and the depth of the localization tree.This PR fixes it by resolving all of the entry's localizations once per cascade and looking each locale up from there. Terms still use
in(), since that doesn't query anything.Measured with the Eloquent driver (queries per cascade):
Related: statamic/cms#15645