[6.x] Fix recache token leaking into pagination links - #15297
Open
lazerg wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The red Windows shard is |
Member
|
I've just re-ran the Windows tests and they seem to be passing now. I've opened #15298 to fix the flakey test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With background recache enabled, pages rendered by a recache request emitted pagination links containing the
__recachetoken, and that HTML got written to the static cache, so the token was served to everyone until the page was regenerated by an ordinary request.The paginator's
withQueryString()appended the raw request query string, token included. It also bypassed Laravel'sPaginator::queryStringResolver(), so the usual way of filtering pagination query params never got called. It now goes through the resolver and drops the recache token.Fixes #15294