[6.x] fix(combobox): handle object values in selectedOptions lookup#14452
Closed
waldemar-p wants to merge 1 commit intostatamic:6.xfrom
Closed
[6.x] fix(combobox): handle object values in selectedOptions lookup#14452waldemar-p wants to merge 1 commit intostatamic:6.xfrom
waldemar-p wants to merge 1 commit intostatamic:6.xfrom
Conversation
The selectedOptions computed property failed to find matching options when
modelValue contained full option objects (e.g., {label, value}) instead of
primitive values. This caused the #selected-option slot to receive fallback
objects with incorrect labels.
Now properly extracts the optionValue from object-type values before
performing the lookup, ensuring the full option object is returned to
slot templates.
Closed
Member
|
Thanks for the pull request! 🙌 This only seems to cover the "currently selected options" case though. There's a lot of other places we assume the value is going to be a string, or an array of strings. For example:
CleanShot.2026-04-08.at.11.22.58.mp4We're also in the midst of a big rewrite of the Combobox (#13843) to improve performance and the UX. Merging this now would lead to a bunch of merge conflicts. For these reasons, I'm going to close this PR. We can re-consider once the rewrite has been merged. Thanks for your understanding! |
Contributor
Author
|
Thanks for the infos and the feedback. I'll then patiently wait for the rewrite of the Combobox. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selectedOptions computed property failed to find matching options when modelValue contained full option objects (e.g., {label, value}) instead of primitive values. This caused the #selected-option slot to receive fallback objects with incorrect labels.
Now properly extracts the optionValue from object-type values before performing the lookup, ensuring the full option object is returned to slot templates.