[6.x] Ignore toolbar shortcuts while inside menus#14111
Open
daun wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Ignore toolbar shortcuts while inside menus#14111daun wants to merge 1 commit intostatamic:6.xfrom
daun wants to merge 1 commit intostatamic:6.xfrom
Conversation
Signed-off-by: Philipp Daun <post@philippdaun.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14110 by checking for open dropdown menus in addition to open modals to prevent triggering floating toolbar keyboard actions. Avoids issues with hitting
Escin an actions menu which would also clear the current selection.