Skip to content

[6.x] Adjust SVG dimensions #14005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Feb 20, 2026
Merged

[6.x] Adjust SVG dimensions #14005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85bcd67
Make SVG dimensions integers so in the meta data you see a nice numbe…
jaygeorge Feb 19, 2026
25a84d0
leave the floats in PHP and just do the rounding in JavaScript. Use M…
jaygeorge Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/components/assets/Editor/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@

<div class="flex w-full items-center justify-end rounded-b border-t dark:border-gray-700 bg-gray-100 dark:bg-gray-900 px-4 py-3">
<div class="hidden h-full flex-1 gap-2 sm:gap-3 py-1 sm:flex">
<ui-badge pill v-if="asset.width && asset.height" icon="assets" :text="__('messages.width_x_height', { width: asset.width, height: asset.height })" />
<ui-badge pill v-if="asset.width && asset.height" icon="assets" :text="__('messages.width_x_height', { width: Math.round(asset.width), height: Math.round(asset.height) })" />
<ui-badge pill icon="memory" :text="asset.size" />
<ui-badge pill icon="fingerprint">
<time
Expand Down
2 changes: 1 addition & 1 deletion src/Imaging/Attributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ private function svgAttributes(string $path)
} elseif ($svg['viewBox']) {
[,,$width, $height] = preg_split('/[\s,]+/', $svg['viewBox'] ?: '');

return compact('width', 'height');
return ['width' => (float) $width, 'height' => (float) $height];
}

return $this->defaultSvgAttributes();
Expand Down