[6.x] Fit more filename characters into asset grid#13979
Open
daun wants to merge 18 commits intostatamic:6.xfrom
Open
[6.x] Fit more filename characters into asset grid#13979daun wants to merge 18 commits intostatamic:6.xfrom
daun wants to merge 18 commits intostatamic:6.xfrom
Conversation
Member
|
Love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor asset filenames to display more of the filename when truncating.
Before
16 characters per filename.
After
21-23 characters per filename, around 40% improvement.
Possible improvements
Make the component available in the UI packageWouldn't work without thatInline the middle ellipsis logic from the package to save a few kBDone, saved 3 kB and simplified thingsCredits
The core logic (though much simplified for our use case) is from dynamic-middle-ellipsis. The package also provides a script for generating the custom character width map.