feat(docker): add isolated_paths for per-repo container-only dirs like node_modules - #46
Merged
Merged
Conversation
…ge per-repo volumes
…ved sandbox management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On macOS/Windows hosts the Docker sandbox shares the host's
node_modules, which only has host-platform native binaries (Nx, esbuild, swc, …), so they fail in the Linux container. Annpm ci/bun installinside the sandbox also overwrites the host's install.This adds an opt-in
isolated_pathssetting that mounts a per-repo Docker volume over each listed directory, so the container gets its own copy and the host's is never touched:Or per run:
--docker-isolated-paths node_modules,.venv.Changes
..) inagent validateand at run timeagent docker cleanup --isolated-pathsto list/remove the volumesagent docker shellsection from feat(docker): addagent docker shelland persist global npm/pip installs in agent home #45Notes
memory/cpuswere added)