fix: prevent TUI crash when opening gallery item in browser#29
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent TUI crash when opening gallery item in browser#29cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dylan Boudro <starmorph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[o]to open a generation in the browser.openInBrowserhelper insrc/core/browser.tsand exports it viasrc/core/index.ts.GalleryDetailto handle browser-open failures with an awaited promise +.catch(...)and display an in-app error instead of crashing.src/core/browser.test.tsto validate successful opener invocation and failure propagation.Bug / impact
On systems where launching a browser fails (common in headless terminals, CI shells, or misconfigured desktop environments), pressing
[o]in gallery detail caused an unhandled promise rejection. In current Node runtimes this terminates the process, abruptly killing the TUI session and interrupting user workflow.Root cause
open()was called inside an Ink input handler without awaiting or catching the returned promise. Rejections escaped the handler and became process-level unhandled rejections.Validation
pnpm typecheck✅pnpm build✅pnpm test✅ (31 tests, including new browser helper tests)Scope
Minimal, high-confidence fix focused only on the crash path; no broad refactors.