fix: prevent GalleryDetail browser-open failures from crashing TUI#27
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent GalleryDetail browser-open failures from crashing TUI#27cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dylan Boudro <starmorph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GalleryDetailto handle failures by surfacing an error message instead of allowing an unhandled rejectionErrorrejection, and non-Errorrejection pathsBug and impact
Pressing
oin gallery detail triggeredopen(...)withoutawaitor.catch(...). If browser launch fails (for example, missing/broken opener on headless/minimal environments), the promise rejects unhandled. In Node 22, unhandled rejections terminate the process, causing immediate TUI exit (significant user-facing breakage in a critical interaction path).Root cause
A behavioral change switched gallery detail from synchronous navigation to async browser launch, but the new async call was fire-and-forget with no rejection handling.
Fix
safeOpenhelper (src/core/safe-open.ts) to contain and normalize browser-launch errors.src/screens/GalleryDetail.tsxto callsafeOpenand set screen error state on failure.src/core/safe-open.test.tsto lock in rejection handling behavior.Validation
pnpm test src/core/safe-open.test.ts✅pnpm typecheck✅