fix: prevent GalleryDetail browser-open crash in TUI#26
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent GalleryDetail browser-open crash in TUI#26cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dylan Boudro <starmorph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GalleryDetailintroduced by the[o] open in browseractionopen(...)call in a handled promise (void ... .catch(...)) instead of firing an unhandled async rejectionFailed to open browseror underlying message) in the existing error stateCritical bug
When the user presses
[o]in gallery detail and the system opener fails (e.g. no desktop opener, missingxdg-open, headless environment),open()rejects. The previous code invokedopen(...)withoutawait/.catch(), creating an unhandled promise rejection from an input handler. On modern Node runtimes this can terminate the process, crashing the TUI.Validation
pnpm typecheckpassespnpm build && pnpm testpasses (29 tests)