fix: prevent GalleryDetail crash when browser launch fails#25
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent GalleryDetail crash when browser launch fails#25cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dylan Boudro <starmorph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GalleryDetailwhen pressing[o]to open a generation and system browser launch failsopenGenerationInBrowser) that catches launch errors and returns a typed messageGalleryDetailto call the helper withvoid ...then(...)and surface a non-fatal warning in the UI instead of crashingBug and impact
Pressing
[o] open in browserinGalleryDetailcould terminate the entire CLI/TUI session in headless or unsupported environments (or when no browser handler is available). This is a high-severity user-facing breakage because a single keypress exits the app unexpectedly.Root cause
open(...)was called in an InkuseInputhandler without awaiting or catching rejection. In Node, unhandled promise rejections terminate the process, so browser-launch failure crashed the app.Fix and validation
string | nullGalleryDetailnow handles failures by showingCould not open browser: ...and keeps the app runningpnpm typecheckpnpm test src/core/browser.test.tspnpm test src/core/clipboard.test.ts