Fix #2541: use UserAgent from RequestContext for the metrics tag - #2543
Open
erichare wants to merge 5 commits into
Open
Fix #2541: use UserAgent from RequestContext for the metrics tag#2543erichare wants to merge 5 commits into
erichare wants to merge 5 commits into
Conversation
Falls back to the full header when there is no RequestContext.
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
erichare
marked this pull request as draft
August 12, 2026 21:47
erichare
marked this pull request as ready for review
August 12, 2026 22:11
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
TenantRequestMetricsTagProviderwas splitting the User-Agent header itself, it now usesUserAgent.product()from theRequestContextso the processing stays in the one place. When there is noRequestContextthe tag falls back to the full header string, and tounknownwhen there is no header.Which issue(s) this PR fixes:
Fixes #2541
Checklist