docs: close the last two open plans - #67
Merged
Merged
Conversation
Both plans in docs/plans/ were done except for tails that will never be picked up, so they move to completed/ with what actually happened written into them. 20260724-selection-index-units: items 1-3 landed in main (indexOfMeta in both handlers, trackTool carrying the existing entry forward, buildToolRows truncating instead of wrapping). Item 4 — handleMouse reading YOffset after setFocus re-clamped it — is closed unfixed by the owner's call, so the new Outcome section is the only record of the defect and where the fix goes. 20260730-update-completion-signal: the code is merged; the two remaining boxes were the live `go run .` (never performed — it installs a real package and needs a TTY) and the move itself. The live-run box is no longer a checkbox, and Post-Completion now says its manual verification never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/plans/had two plans sitting outsidecompleted/. Both were done except for tails nobody is going to pick up, so they move over with what actually happened written into them — a plan filed as completed should not leave a reader guessing which of its items shipped.20260724-selection-index-units.mdItems 1-3 are in
mainalready:updateTrackInput/updateRenameInputgo throughm.indexOfMeta(name)(internal/model/mode.go:196,:304) instead of scanningm.metafor a file-order index.trackToolcarriesNote,Tags,UpdateCmd,Addedand a ref-less input'sGitHubforward from the existing entry.buildToolRowstruncates the name (truncateToWidth(flattenLine(mt.Name), nameBudget),internal/model/render.go:1225) instead of wrapping it into a second screen line.Item 4 is closed unfixed, on the owner's call.
handleMousestill readsm.toolsViewport.YOffsetaftersetFocus(focusTools)has re-clamped it (internal/model/render.go:2230-2235), so a click following a wheel scroll from another panel can land on a neighbouring tool. It is tracked nowhere else, so the new## Outcomesection is the whole record: what the defect is, where it lives, and that the fix is to capture the offset before thesetFocuscall.20260730-update-completion-signal.mdCode merged long ago; two boxes were still open. The live
go run .against a tool with a pending update was never performed and will not be — it installs a real package and needs a TTY — so it stops being a checkbox and says so, andPost-Completionnow states its manual verification never ran. The other box was the move itself.No code changes.