docs: make theme.go state the two palettes it does not own - #66
Merged
Conversation
Three documents claimed the contract change from #65 was recorded in theme.go. It was not: the file still said switching every color in keepkit is switching one Theme value, which stopped being true for panel [3]'s heading ladder and code-fence accents. The file that defines the rule is the one a contributor reads before adding a color. Also drops two stale claims the same pass turned up: CLAUDE.md called LanguageColor the one palette a theme switch must not repaint while its own internal/ui row already said there were two, and the readme pipeline doc said no general sanitizer is pulled in when glamour v1.0.0 holds a bluemonday.StrictPolicy and has put it in go.mod all along. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65. A docs-sync pass over the merged palette contract found three statements that are now false; all three are comment/prose edits, no behaviour change.
internal/ui/theme.go— the one that matters. #65 moved panel[3]'s heading ladder and code-fence accents offThemeroles, and three documents say the consequence was recorded intheme.go:CLAUDE.md'sinternal/uirow ("stated in all three of theme.go, readme_palette.go andkeepkitStyle"),docs/design/readme-pipeline.md("stated in three places"), and the palette file's own argument.theme.gowas never in that diff — it still claimed, unqualified, that "switching every color in keepkit is switching one Theme value". The file that defines the rule is the one a contributor reads before adding a color, and it was the only one contradicting the other three. It now narrows its claim to what keepkit paints as a meaning and names both palettes standing outside it.CLAUDE.mdcontradicted itself. Line 48 already said two palettes are not theme roles; the card-meta-block section still calledui.LanguageColor"the one thing in the app a theme switch must not repaint".The bluemonday sentence was stale.
readme-pipeline.mdsaid "no general sanitizer (bluemonday) is pulled in". glamour v1.0.0 holds abluemonday.StrictPolicy()inansi/context.go:26andgo mod whyputs it underinternal/model, somicrocosm-cc/bluemonday v1.0.27has been ingo.modas an indirect dependency all along. Reworded to say what the preprocessor actually buys — control over which tags keep their bodies, which a strict policy flattens uniformly.docs/research/glow-comparison.md, which landed in #65, had already flagged this; the sentence it points at went unfixed.Also verified, no drift
go list— every drawn edge exists, every real edge is drawn, includingui → loader.go.mod.[3]copy already says the headings follow keepkit's own palette.Note
CLAUDE.mdis at 146 537 characters against the harness's 150 000 limit — about 3 400 to spare. Worth splitting the next large section intodocs/design/before something else needs the room.Preflight green: build, vet,
test -race ./...,golangci-lint run(0 issues), plus the Windows/darwin cross-compile.