fix: tone code spans and blocks down to body brightness - #62
Merged
Conversation
Inline code and code blocks in the readme panel and the card's changelog rendered in Emphasis (#F2F3F5) on the Surface plate — the brightest text role, spent dozens of times per screen, which made every literal the loudest thing in the panel. The plate alone is what marks a literal, so the text now stays at the body Text role in all three render paths (glamour inline/chroma/Ascii fallback) and the changelog's mdCode plate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline code and code blocks rendered in
Emphasis(#F2F3F5) on theSurfaceplate. That role is meant to peak a few times per frame, and a README spends dozens of code spans per screen — every literal was the loudest thing in the panel.The plate alone marks a literal, so the text drops to the body
Textrole (#A8ADB8). Same rule, stated in two panels, changed in all four places:cfg.Code.Color)Texttoken only, syntax accents untouchedcfg.CodeBlock.Color)mdCodeplate (render.go)Tests: updated the role assertions in
readme_style_test.go, plus two gaps closed — the Ascii-fallbackCodeBlock.Colorwas never pinned (a mutant keepingEmphasisthere survived the suite), andTestChangelogBlockIndentAndCodePlatechecked only the background, now also the foreground role. All four production edits mutation-checked: each revert goes red.Docs: CLAUDE.md and
docs/design/readme-pipeline.mdcarried the old rule with its rationale; both now record whyEmphasisovershot.