Skip to content

Replace Boost Regex with std::locale #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrjohns merged 3 commits into from
Aug 25, 2026
+8 −4
Merged

Replace Boost Regex with std::locale #3409

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f1d851
Replace boost/regex with std locale
andrjohns Aug 24, 2026
f6b7ec0
Default to C locale for varname val
andrjohns Aug 24, 2026
f6b5fbf
Update src/stan/io/json/json_data_handler.hpp
andrjohns Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/stan/io/json/json_data_handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#include <stan/io/json/json_handler.hpp>
#include <stan/io/json/rapidjson_parser.hpp>
#include <stan/io/var_context.hpp>
#include <cctype>
#include <iostream>
#include <locale>
#include <ostream>
#include <limits>
#include <map>
Expand All @@ -16,7 +16,6 @@
#include <utility>
#include <vector>
#include <boost/algorithm/string.hpp>
#include <boost/regex.hpp>

namespace stan {

Expand Down Expand Up @@ -172,8 +171,13 @@ class json_data_handler : public stan::json::json_handler {
* and contain only letters, numbers, or an underscore.
*/
bool valid_varname(const std::string& name) {
static const boost::regex re("[a-zA-Z][a-zA-Z0-9_]*");
return boost::regex_match(name, re);
static const std::locale& locale = std::locale::classic();
if (name.empty() || !std::isalpha(name[0], locale)) {
Comment thread
WardBrian marked this conversation as resolved.
return false;
}
return std::all_of(name.cbegin() + 1, name.cend(), [](const char c) {
return std::isalnum(c, locale) || c == '_';
});
}

bool is_array_tuples(const std::vector<std::string>& keys) {
Expand Down
Loading