Skip to content

Fix ps_point reserve capacity #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveBronder wants to merge 1 commit into
base: develop
Choose a base branch
from
+27 −2
Open

Fix ps_point reserve capacity #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/stan/mcmc/hmc/hamiltonians/ps_point.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ps_point {

virtual inline void get_param_names(std::vector<std::string>& model_names,
std::vector<std::string>& names) {
names.reserve(q.size() + p.size() + g.size());
names.reserve(names.size() + q.size() + p.size() + g.size());
for (int i = 0; i < q.size(); ++i)
names.emplace_back(model_names[i]);
for (int i = 0; i < p.size(); ++i)
Expand All @@ -34,7 +34,7 @@ class ps_point {
}

virtual inline void get_params(std::vector<double>& values) {
values.reserve(q.size() + p.size() + g.size());
values.reserve(values.size() + q.size() + p.size() + g.size());
for (int i = 0; i < q.size(); ++i)
values.push_back(q[i]);
for (int i = 0; i < p.size(); ++i)
Expand Down
25 changes: 25 additions & 0 deletions src/test/unit/mcmc/hmc/hamiltonians/ps_point_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,30 @@ TEST(psPoint, write_metric_streams) {
EXPECT_EQ("", stan::test::cerr_ss.str());
}

TEST(psPoint, get_param_names_appends_to_existing_names) {
ps_point point(2);
std::vector<std::string> model_names{"alpha", "beta"};
std::vector<std::string> names{"lp__"};

point.get_param_names(model_names, names);

std::vector<std::string> expected{"lp__", "alpha", "beta", "p_alpha",
"p_beta", "g_alpha", "g_beta"};
EXPECT_EQ(expected, names);
}

TEST(psPoint, get_params_appends_to_existing_values) {
ps_point point(2);
point.q << 1.0, 2.0;
point.p << 3.0, 4.0;
point.g << 5.0, 6.0;
std::vector<double> values{-1.0};

point.get_params(values);

std::vector<double> expected{-1.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0};
EXPECT_EQ(expected, values);
}

} // namespace mcmc
} // namespace stan
Loading