unify docs to use variable instead of variables#436
Conversation
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ebb53ec is merged into master:
|
|
So you changed the name in the doc but the argument name in the function remained the same? If so, this should lead to an R CMD check failure du to code-documentionat mismatch. Or am I misreading something? |
|
I think this is what we did discuss, but I guess I did misunderstood. How would you solve this? |
|
Either rename the argument names too (breaks backwards compatibility) or leave things as is. The latter would mean that using "variable" still works due to R's partial matching of argument names. The former would mean that only "variable" would work but "variables" would no longer work. Not sure if that is desirable. I am sorry I haven't been clear with this previously. @florence-bockting perhaps you have some other ideas? |
Summary
Closes #429
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: