Skip to content

Parallelize some functions - #371

Open
VisruthSK wants to merge 8 commits into
masterfrom
parallelize
Open

VisruthSK wants to merge 8 commits into
masterfrom
parallelize

Conversation

@VisruthSK

@VisruthSK VisruthSK commented Jun 7, 2026 •

Copy link
Copy Markdown
Member

This PR was made with assistance from Codex.

Fixed elpd_loo_approximation() to push cores through to loo.function().

Used standard parallelization in waic.function() instead of plain lapply().

Fixed stray line in ap_psis.array() and pass cores through to ap_psis.matrix().

@codecov-commenter

codecov-commenter commented Jun 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.47%. Comparing base (b22ea49) to head (79a2de5).

Files with missing lines Patch % Lines
R/waic.R 70.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   92.50%   92.47%   -0.03%     
==========================================
  Files          31       31              
  Lines        3107     3138      +31     
==========================================
+ Hits         2874     2902      +28     
- Misses        233      236       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 7, 2026 •

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 79a2de5 is merged into master:

  • ✔️loo_function: 1.85s -> 1.85s [-0.33%, +0.23%]
  • ✔️loo_matrix: 1.6s -> 1.6s [-0.37%, +0.19%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@VisruthSK
VisruthSK marked this pull request as ready for review June 7, 2026 04:12
@VisruthSK VisruthSK added this to the v2.11.0 milestone Jul 24, 2026
@VisruthSK
VisruthSK requested a review from jgabry October 10, 2026 18:29
@jgabry

jgabry commented Oct 12, 2026

Copy link
Copy Markdown
Member

Can you fix the merge conflicts on this and then I'll review?

Comment thread R/loo_subsample.R
Comment thread .Rbuildignore
Comment thread R/psis_approximate_posterior.R
Comment thread R/waic.R

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ok to merge when CI passes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants