refactor(players): delete dead VideoPlayer that restarted a unit that does not exist (869f8v8yv) - #21
Merged
Merged
Conversation
… does not exist (869f8v8yv) VideoPlayer was never instantiated, and its own docstring said not to use it. Its run() restarted 'videocomposer.service'; the real unit is cuems-videocomposer.service. Deleted rather than fixed: a working restart would cut live video and leave the engine holding layers the fresh videocomposer no longer has (869f8jn34), against the never-auto-stop rule. Also drops CueHandler._video_players and _front_video_player, written in __new__ and never read, and the stale 'VideoPlayer was called' assertion in testdev_engines_communication.py (not collected by pytest). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ClickUp 869f8v8yv.
Problem
VideoPlayer(players/VideoPlayer.py) was dead code. Nothing instantiated it, and its own docstring said not to use it. It was also broken:run()restartedvideocomposer.service, and that unit does not exist (the real one iscuems-videocomposer.service).Why delete it instead of fixing the unit name
With a correct name, the engine would gain a working way to restart the videocomposer. That restart cuts the video on screen and leaves the engine holding layers the fresh videocomposer no longer has (869f8jn34), which breaks the "never auto-stop a running project" rule.
Changes
VideoPlayerclass and its export fromplayers/__init__.py.VideoClientandVideoOutputstay.CueHandler._video_playersandCueHandler._front_video_player. They were set in__new__and never read.NodeEngine.set_video_playersis unrelated and unchanged.tests/test_action_cue.py.tests/testdev_engines_communication.py, which pytest does not collect, remove the "VideoPlayer was called" assertion. It was already false, because nothing created aVideoPlayer.Testing
On test2, the engine suite was run on
rc_1(956a0f3) and on this branch, from separate checkouts, alternating:rc_1: 818 passed, 3 of 3 runs;This branch's first run died silently inside
test_project_go.py. The cause is unrelated to this change: a wiring race between libmtcmaster andcuems-midiconnector, reproduced at 67/3011 with the connector running and 0/2744 with it stopped. It is tracked as ClickUp 869f8xepw.Also on test2: the package imports, and the class and both attributes are gone.