fix(ci): install librtmidi6 so the unit tests can run - #19
Merged
Merged
Conversation
The tests job unpacks libmtcmaster with dpkg --force-depends, which skips its Depends -- including librtmidi6 (librtmidi.so.6). Every test that imports cuemsengine then errored on "libmtcmaster import error: librtmidi.so.6: cannot open shared object file", so CI on rc_1 has run 0 tests since at least 2026-08-10 (653 errors then, 764 on 30cbbfb). librtmidi6 5.0.0-2 is in jammy universe, the tests runner's release. Also adds the SPDX header the workflow lacked.
With the librtmidi6 fix the unit tests run again, and one fails: test_audio_start_value_defaults_to_100_when_no_master_vol_predefined got start_value 0.01, expected 1.0. poetry.lock pinned cuemsutils 0.1.0rc11, where AudioCue.master_vol still defaults to 1 (the old 0.0-1.0 scale); 0.1.0rc13 moved it to 100 (0-100 percent), which is what FadeActionHandler divides by 100. Locally the editable rc14 hid it. The test is right: on rc11 a fade from a fresh AudioCue starts at 1%. Raise the floor to >=0.1.0rc13 and relock (rc14, from PyPI); nothing else in the lock moved. The fleet already runs cuems-utils rc14, so production was not affected -- the deb takes cuemsutils from the cuems-utils package. Also adds the SPDX header pyproject.toml lacked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests job unpacks
libmtcmasterwithdpkg --force-depends, which skips its dependencies, includinglibrtmidi6. Every test that importscuemsenginethen fails withlibmtcmaster import error: librtmidi.so.6: cannot open shared object file, so CI onrc_1has run 0 tests since at least 2026-08-10 (653 errors on fc8d2bb, 764 on 30cbbfb).librtmidi65.0.0-2 is in jammy universe (the tests runner isubuntu-22.04); this adds it to the system-packages step. It also adds the SPDX header the workflow was missing.Merge once this PR run shows the unit tests actually executing.