Support multi-cluster deployments (Central + SecuredCluster on separate clusters)#105
Conversation
49fa237 to
a0ffb80
Compare
|
This will be very helpful for Infra and e2e testing. In Infra/Automation, we've had a long-term todo of adding multi-cluster capability to the demo (ansible scripts) and repeated asks/investigations on various teams have looked at multi-cluster deploys for automated testing. |
31a0cfc to
ce1d010
Compare
ce1d010 to
1817bee
Compare
|
Holding this PR until we can have further discussions around the UX of the feature. |
1817bee to
d81f08c
Compare
99c5975 to
7755974
Compare
7755974 to
954384a
Compare
|
Ready for re-review @porridge @mclasmeier |
porridge
left a comment
There was a problem hiding this comment.
FTR I don't have anything to add over what @mclasmeier wrote.
…ndpoint; update README examples
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR enables hub-and-spoke multi-cluster deployments by allowing an explicit ChangesMulti-cluster deployment support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mclasmeier
left a comment
There was a problem hiding this comment.
looking good, thank you, just a few nits for the test.
Summary
Roxie currently assumes Central and SecuredCluster are deployed on the same Kubernetes cluster. Many ACS customers and internal teams run a hub + spoke architecture where Central lives on one cluster and one or more SecuredClusters are deployed to separate clusters. This PR adds multi-cluster support so that roxie can deploy a SecuredCluster that points to a Central running on a different cluster.
Users set the SecuredCluster CR's
centralEndpointdirectly via config file:When
spec.centralEndpointis provided, roxie preserves it. When it is not set, roxie defaults to the internalcentral.<namespace>.svc:443endpoint, preserving full backward compatibility. Authentication to Central for CRS generation uses the existingROX_ADMIN_PASSWORDandROX_CA_CERT_FILEenvironment variables.Testing
spec.centralEndpointpointing to cluster A — both deployed and connected successfully, sensor logs confirmed connection to remote CentralCloses #99
Summary by CodeRabbit
Release Notes
Documentation
Improvements