Pin mcp-server-time e2e image by digest - #6160
Merged
Merged
Conversation
The proxy e2e suites fail on every PR with "timeout waiting for MCP server to be ready". Same root cause as #6159, a different image: tag 2026.7.10 of mcp-server-time is mutable, dockyard rebuilds it and resolves Python dependencies fresh, and the 2026-07-31 rebuild picked up the mcp Python SDK 2.0.0 released 2026-07-28. mcp-server-time imports McpError from mcp.shared.exceptions, which 2.x moved, so the container now exits on startup with "ImportError: cannot import name 'McpError'". Pin the last build that resolved a 1.x mcp. Verified by driving both builds over stdio: the pinned digest answers initialize, tag 2026.7.10 does not. Point the two affected suites at the pinned constant instead of the "time" registry entry, since the registry resolves to the moving tag and is not fixable from this repo. Registry-name resolution stays covered by the sibling cases that run "osv". stdio_proxy_over_streamable_http gains an explicit --transport stdio, which the registry entry previously supplied. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
amirejaz
requested review from
ChrisJBurns,
JAORMX,
aponcedeleonch,
jhrozek,
rdimitrov and
reyortiz3
as code owners
July 31, 2026 15:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6160 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 736 736
Lines 76331 76331
=======================================
+ Hits 55391 55393 +2
+ Misses 17019 17017 -2
Partials 3921 3921 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jerm-dro
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E Tests Core (proxy)is failing on every PR in the repo withtimeout waiting for MCP server to be ready. Three specs fail:TimeStreamableHttpMcpServer, and bothProxy Stdio E2Eproxy modes.Same root cause as #6159, a different image. Tag
2026.7.10ofmcp-server-timeis mutable; dockyard rebuilds it and resolves Python dependencies fresh each time. The 2026-07-31 rebuild picked up the mcp Python SDK 2.0.0 released 2026-07-28.mcp-server-timeimportsMcpErrorfrommcp.shared.exceptions, which 2.x moved, so the container now exits on startup:The server never becomes ready, and the proxy suites time out waiting for it.
mcp-server-timeto the last build that resolved a 1.x mcp (sha256:5cca77de…, the 2026-07-27 build of the same tag)."time"registry entry. The registry resolves"time"to the moving:2026.7.10tag and is not fixable from this repo, so referencing it leaves CI hostage to an upstream rebuild.stdio_proxy_over_streamable_http_mcp_server_test.gogains an explicit--transport stdio, which the registry entry previously supplied.Type of change
Test plan
task test-e2e)task lint-fix)Ran both affected suites locally against a locally-built
thv:"time")TimeStreamableHttpMcpServertimeout waiting for MCP server to be readyProxy Stdio E2E(both modes)The unpinned run reproduces the CI error exactly, at the same assertion (
stdio_proxy_over_streamable_http_mcp_server_test.go:60).Also confirmed the two builds differ by driving each directly over stdio with an
initializerequest: the pinned digest returns a result, tag2026.7.10exits with theImportErrorabove.task lint-fixis clean on the changed files; the one remaining finding (cmd/thv/app/upgrade.gogosec G115) is pre-existing and untouched.Does this introduce a user-facing change?
No. Test-only.
Special notes for reviewers
This is repo-wide, not specific to any PR. Confirmed by re-running an unrelated PR's previously-green E2E job: same code, 14 hours later, same failure. Unrelated open PRs (#6157, #6150) show the identical
35 Passed | 3 Failed. The last green proxy runs were 2026-07-30 ~14:25.Coverage tradeoff. These two suites no longer exercise registry-name resolution for
"time". That path is still covered by the sibling cases inproxy_stdio_test.gothat run"osv", so nothing is lost overall — and the alternative is CI that any upstream rebuild can break.Second mutable-tag breakage in two days. #6159 pinned
ida-pro-mcpfor the same reason. Both are dockyarduvximages with unboundedmcp>=constraints meeting the 2.0.0 release. A sweep pinning the remaining dockyarduvximages by digest — or capping the constraint upstream — would stop this recurring;pagerduty-mcpis already safe because it capsmcp[cli]~=1.8.Generated with Claude Code