fix: use the invoked trusted workflow revision - #993
Merged
Merged
Conversation
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
danbarr
enabled auto-merge (squash)
September 18, 2026 19:05
JAORMX
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.workflow_shaContext
The final trusted scan for #925 ran after #992 merged, but
github.event.pull_request.base.shastill pointed to29ccd7d, the pull request branchs older merge base. The trusted scan therefore recorded approval hashes for the old workflow implementation. When the merge commit reachedmain, the build correctly rejected every approval withtrusted scan implementation changed after approvaland fell back to fresh LLM scans. Two fresh verdicts then blocked publication in run 35362527423.github.workflow_shaidentifies the exact trusted commit from which GitHub loaded thepull_request_targetworkflow. Checking out that revision keeps the executed workflow and its scanner implementation aligned even when the pull request branch is behindmain.Validation
Because
pull_request_targetuses the default-branch workflow definition, this checkout behavior must be confirmed on a skill-changing pull request after merge.