Add opt-in host credential seeding for agent VMs#40
Merged
Conversation
Extend the Store interface with SeedFile (write-once), ReadFile, and OverwriteFile methods so callers can access credential files through the interface instead of reaching around via FSStore.baseDir. Extract shared path validation into a resolvePath helper. OverwriteFile uses atomic temp-file + rename matching the existing extractFile pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Define CredentialSeeder with Seed(store Store) error so each agent can own its host credential seeding logic. Implementations will live in infra and be wired by the composition root. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the SeedClaudeCodeCredentials function with a ClaudeCodeSeeder struct that implements the domain CredentialSeeder interface. Uses Store.ReadFile/OverwriteFile instead of reaching around FSStore.baseDir. Trim Keychain output, bound credential size, and make host credential reader swappable for testability. Tests exercise Seed() end-to-end. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add SeedHostCredentials to AuthConfig (opt-in, default false) with --seed-credentials CLI flag. Local workspace config values are explicitly ignored in MergeConfigs to prevent supply-chain attacks. Security warning surfaces override attempts to the user. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract agent-to-seeder dispatch into credentialSeederForAgent switch function returning credential.CredentialSeeder interface. Seeder selection lives in the composition root; failure is non-fatal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Skip the interactive setup wizard which cannot complete inside a headless VM by setting hasCompletedOnboarding in .claude.json during MCP config injection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JAORMX
approved these changes
Mar 16, 2026
jhrozek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--seed-credentialsflag (andauth.seed_host_credentialsconfig) opts in to reading OAuth tokens from the host (macOS Keychain or~/.claude/.credentials.json) and pre-populating the VM credential store. Eliminates the need for browser-based OAuth on first run inside the VM.hasCompletedOnboardingin.claude.jsonso Claude Code skips the interactive wizard inside headless VMs.Credential seeding design
Each agent gets a
Seederimplementation (domain interface inpkg/domain/credential).ClaudeCodeSeederreads the host Keychain/file, comparesexpiresAtwith stored credentials, and writes only if fresher. TheStoreinterface is extended withSeedFile,ReadFile, andOverwriteFileto support individual file operations needed by the seeder.Security constraints:
seed_host_credentialsin workspace.broodbox.yamlis ignored (security warning printed)