Skip to content

fix(validate): extend allowed full version regex to allow patch/pre-release version#1542

Merged
Manuelvaas merged 2 commits into
stackitcloud:mainfrom
RiRa12621:main
Jun 26, 2026
Merged

fix(validate): extend allowed full version regex to allow patch/pre-release version#1542
Manuelvaas merged 2 commits into
stackitcloud:mainfrom
RiRa12621:main

Conversation

@RiRa12621

@RiRa12621 RiRa12621 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

SKE sometimes has a need to release patch versions that don't follow strict semver but also allow prerlease so x.y.z-pre.release
source: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
This changes extends the full version regex and adds tests for it

this fixes #1544

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@RiRa12621 RiRa12621 requested a review from a team as a code owner June 26, 2026 07:43
@RiRa12621

Copy link
Copy Markdown
Contributor Author

Tests pass, doc gen fails locally on some terraform related issue. might make sense to switch this out for opentofu in the future, as terraform has now also been removed from homebrew

@Manuelvaas

Copy link
Copy Markdown
Contributor

Hi @RiRa12621,
thank you for your contribution. We will take a look at it.

Comment thread stackit/internal/validate/validate_test.go
@Manuelvaas Manuelvaas enabled auto-merge (squash) June 26, 2026 11:03
@Manuelvaas Manuelvaas merged commit 4e42f8c into stackitcloud:main Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terraform provider stackit doesn't accept full semvers for ske os versions

4 participants