fix(validate): extend allowed full version regex to allow patch/pre-release version#1542
Merged
Conversation
Contributor
Author
|
Tests pass, doc gen fails locally on some terraform related issue. might make sense to switch this out for opentofu in the future, as terraform has now also been removed from homebrew |
Contributor
|
Hi @RiRa12621, |
crigertg
reviewed
Jun 26, 2026
Manuelvaas
approved these changes
Jun 26, 2026
cgoetz-inovex
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SKE sometimes has a need to release patch versions that don't follow strict semver but also allow prerlease so x.y.z-pre.release
source: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
This changes extends the full version regex and adds tests for it
this fixes #1544
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)