WIP: feat(ske) access ressource#1437
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was closed automatically because it has been stalled for 7 days with no activity. Feel free to re-open it at any time. |
|
@Manuelvaas I think this PR could solve #1360 |
Co-authored-by: Manuel Vaas <34416897+Manuelvaas@users.noreply.github.com>
| if utils.IsUndefined(m.Access) { | ||
| return nil, nil | ||
| } | ||
| access := access{} |
There was a problem hiding this comment.
@cgoetz-inovex for upcoming PRs, please don't shadow struct definitions with variable names if possible 😅
There was a problem hiding this comment.
hmm weird, usually the linter complains about shadowing
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
4 participants
Description
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)