feat: support multi-area and regional hub-spoke topologies - #66
Conversation
…nal-hub-spoke # Conflicts: # CODEOWNERS # src/main.tf # src/modules/connectivity/3-external-network.tf # src/modules/connectivity/README.md
|
Merged current |
| firewall_admin_password = var.firewall_admin_password | ||
| } | ||
|
|
||
| module "connectivity_eu01" { |
There was a problem hiding this comment.
firewall credentials are missing
There was a problem hiding this comment.
Fixed in 2264b28. The eu01 connectivity module now receives firewall_admin_endpoint, firewall_admin_username, and firewall_admin_password.
| } | ||
| } | ||
|
|
||
| variable "firewall_admin_endpoint" { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed in 2264b28. firewall_admin_endpoint is now used for the primary HA configuration and falls back to the firewall public IP when unset.
|
|
||
| owner_email = var.owner_email | ||
| naming_pattern = "${var.company_code}-pltfm-hub-prod" | ||
| naming_pattern = coalesce(var.connectivity.naming_pattern, "${var.company_code}-pltfm-connectivity") |
There was a problem hiding this comment.
Why was the suffix changed? This will change existing landing zone project names.
There was a problem hiding this comment.
Fixed in 2264b28. Restored the legacy ${company_code}-pltfm-hub-prod fallback and preserved unsuffixed names for the default area. Named multi-area resources continue to use their area suffix.
2 participants
Summary
Validation
STACKIT_SERVICE_ACCOUNT_KEY_PATH="$HOME/.ssh/landingzone-sa.json" tofu test -filter=tests/multi_area.tftest.hclSTACKIT_SERVICE_ACCOUNT_KEY_PATH="$HOME/.ssh/landingzone-sa.json" tofu plan -refresh=false -input=false -var-file=config/hub-and-spoke-finance-research.tfvars -no-colorSTACKIT_SERVICE_ACCOUNT_KEY_PATH="$HOME/.ssh/landingzone-sa.json" tofu plan -refresh=false -input=false -var-file=config/hub-and-spoke-tenant-isolation.tfvars -no-colorSTACKIT_SERVICE_ACCOUNT_KEY_PATH="$HOME/.ssh/landingzone-sa.json" tofu plan -refresh=false -input=false -var-file=config/hub-and-spoke-multi-region.tfvars -no-colorgit diff --checkCloses #63