Skip to content

add metrics endpoint for csi#178

Open
aniruddha2000 wants to merge 4 commits into
mainfrom
add-generic-metrics
Open

add metrics endpoint for csi#178
aniruddha2000 wants to merge 4 commits into
mainfrom
add-generic-metrics

Conversation

@aniruddha2000

@aniruddha2000 aniruddha2000 commented Jun 17, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:

This PR exposes endpoint and port for csi metrics using external APIs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 17, 2026
@ske-prow

ske-prow Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2026
nschad
nschad requested changes Jun 18, 2026
View reviewed changes

@nschad nschad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the port to the Service

Comment thread ...plane/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-driver-controller.yaml Outdated
@ske-prow ske-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2026
@aniruddha2000 aniruddha2000 mentioned this pull request Jun 24, 2026
Open
nschad
nschad requested changes Jul 1, 2026
View reviewed changes
Comment thread charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/service.yaml
Comment thread charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/service.yaml
@nschad nschad force-pushed the add-generic-metrics branch from 9058711 to 27abf66 Compare July 1, 2026 09:45
nschad
nschad reviewed Jul 1, 2026
View reviewed changes
Comment thread charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/templates/service.yaml

@nschad nschad Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we (SKE) doesn't need this since we use pod-discovery and not service-discovery. However I don't really mind this, could be useful for somebody other than SKE.

@nschad

nschad commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/hold requires CSI version bump to support setting --metrics-address

/lgtm

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 1, 2026
@ske-prow

ske-prow Bot commented Jul 1, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 3601d9cc4e9c8bffbe01b49c6487e6a1d3a5c156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniruddha2000 @nschad